Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(kit)!: Action refactor to button[tuiAction], a[tuiAction] #2479

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

nsbarsukov
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

Closes #2478

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Aug 26, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit afa13f9):

https://taiga-ui--pr2479-action-refactor-bmz0ku2q.web.app

(expires Sat, 27 Aug 2022 12:45:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #2479 (afa13f9) into v3.x (3b8b0ba) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             v3.x    #2479      +/-   ##
==========================================
+ Coverage   56.89%   56.92%   +0.03%     
==========================================
  Files         962      962              
  Lines        9245     9240       -5     
  Branches     1883     1881       -2     
==========================================
  Hits         5260     5260              
+ Misses       3579     3574       -5     
  Partials      406      406              
Flag Coverage Δ
addon-charts 74.38% <ø> (ø)
addon-doc 19.16% <ø> (ø)
addon-editor 28.81% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 83.78% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 63.89% <ø> (ø)
core 63.12% <ø> (ø)
kit 61.36% <0.00%> (+0.08%) ⬆️
summary 56.92% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
projects/kit/components/action/action.component.ts 18.18% <0.00%> (+5.68%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nsbarsukov nsbarsukov changed the title [WIP] refactor(kit)!: Action refactor to button[tuiAction], a[tuiAction] refactor(kit)!: Action refactor to button[tuiAction], a[tuiAction] Aug 26, 2022
@nsbarsukov nsbarsukov marked this pull request as ready for review August 26, 2022 13:18
@nsbarsukov nsbarsukov merged commit 604fbf5 into v3.x Aug 26, 2022
@nsbarsukov nsbarsukov deleted the action-refactor branch August 26, 2022 13:18
@well-done-bot
Copy link

well-done-bot bot commented Aug 26, 2022

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants