Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: delete tui-palette.less (data-tui-background and data-tui-color states) #2473

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

nsbarsukov
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Aug 26, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2022

Visit the preview URL for this PR (updated for commit 41ad183):

https://taiga-ui--pr2473-remove-deprecations-6fn74zpd.web.app

(expires Sat, 27 Aug 2022 13:23:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #2473 (41ad183) into v3.x (604fbf5) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             v3.x    #2473      +/-   ##
==========================================
+ Coverage   56.83%   56.92%   +0.09%     
==========================================
  Files         969      961       -8     
  Lines        9273     9239      -34     
  Branches     1884     1881       -3     
==========================================
- Hits         5270     5259      -11     
+ Misses       3597     3574      -23     
  Partials      406      406              
Flag Coverage Δ
addon-charts 74.38% <ø> (ø)
addon-doc 19.16% <ø> (ø)
addon-editor 28.81% <100.00%> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 83.78% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 63.89% <ø> (ø)
core 63.10% <ø> (-0.02%) ⬇️
kit 61.36% <ø> (+0.29%) ⬆️
summary 56.92% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...it/components/input-count/input-count.component.ts 76.62% <ø> (ø)
...don-editor/extensions/default-editor-extensions.ts 100.00% <100.00%> (ø)
projects/addon-editor/extensions/indent-outdent.ts 20.00% <100.00%> (ø)
projects/kit/components/push/push.service.ts
projects/kit/components/push/push.component.ts
...ojects/kit/components/push/push-alert.directive.ts
projects/kit/components/push/push.directive.ts
projects/kit/components/push/push.module.ts
projects/kit/components/push/push.options.ts
...ojects/kit/components/push/push-alert.component.ts

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@waterplea waterplea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully palette removal did not leave any unexpected issues :)

@nsbarsukov nsbarsukov changed the title refactor!: delete some deprecations feat!: delete tui-palette.less (data-tui-background and data-tui-color states) Aug 26, 2022
@nsbarsukov nsbarsukov merged commit 4655609 into v3.x Aug 26, 2022
@nsbarsukov nsbarsukov deleted the remove-deprecations branch August 26, 2022 13:57
@well-done-bot
Copy link

well-done-bot bot commented Aug 26, 2022

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants