Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: replace setNativeFocused(el) with el.focus() #2276

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

nsbarsukov
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

setNativeFocused(element, true, true);

What is the new behavior?

element.focus({preventScroll: true})

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Aug 4, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

Visit the preview URL for this PR (updated for commit cf4a5f1):

https://taiga-ui--pr2276-rm-set-native-focuse-e3f64m6b.web.app

(expires Fri, 05 Aug 2022 09:32:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #2276 (cf4a5f1) into v3.x (6765d05) will decrease coverage by 0.03%.
The diff coverage is 29.72%.

@@            Coverage Diff             @@
##             v3.x    #2276      +/-   ##
==========================================
- Coverage   56.42%   56.39%   -0.04%     
==========================================
  Files         971      970       -1     
  Lines        9570     9567       -3     
  Branches     1951     1949       -2     
==========================================
- Hits         5400     5395       -5     
- Misses       3739     3741       +2     
  Partials      431      431              
Flag Coverage Δ
addon-charts 73.84% <ø> (ø)
addon-doc 18.87% <ø> (ø)
addon-editor 28.96% <0.00%> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 83.78% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 64.15% <14.28%> (-0.21%) ⬇️
core 66.85% <40.00%> (ø)
kit 58.44% <36.36%> (ø)
summary 56.39% <29.72%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/toolbar/toolbar-navigation-manager.directive.ts 3.57% <0.00%> (ø)
...don-editor/components/toolbar/toolbar.component.ts 5.79% <0.00%> (ø)
.../cdk/directives/focus-trap/focus-trap.directive.ts 5.88% <0.00%> (ø)
...ojects/cdk/utils/focus/set-native-mouse-focused.ts 0.00% <0.00%> (ø)
.../data-list/data-list-dropdown-manager.directive.ts 10.20% <0.00%> (ø)
...re/components/data-list/option/option.component.ts 70.58% <0.00%> (ø)
...ts/kit/components/combo-box/combo-box.component.ts 51.66% <0.00%> (ø)
...it/components/input-count/input-count.component.ts 75.94% <0.00%> (ø)
...it/components/input-phone/input-phone.component.ts 58.00% <0.00%> (ø)
.../kit/components/pagination/pagination.component.ts 50.00% <0.00%> (ø)
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tinkoff-bot tinkoff-bot force-pushed the rm-set-native-focused branch from f93d4ab to cf4a5f1 Compare August 4, 2022 09:29
@nsbarsukov nsbarsukov merged commit 009df69 into v3.x Aug 4, 2022
@nsbarsukov nsbarsukov deleted the rm-set-native-focused branch August 4, 2022 10:03
@well-done-bot
Copy link

well-done-bot bot commented Aug 4, 2022

'Well done'

This was referenced Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants