Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove deprecated properties from AbstractTuiInteractive #2124

Merged
merged 3 commits into from
Jul 15, 2022

Conversation

vladimirpotekhin
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jul 14, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2022

Visit the preview URL for this PR (updated for commit 6f3ba04):

https://taiga-ui--pr2124-interactive-deprecat-6xmfahfp.web.app

(expires Sat, 16 Jul 2022 09:05:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #2124 (6f3ba04) into v3.x (5c1c7f1) will increase coverage by 0.39%.
The diff coverage is 53.84%.

@@            Coverage Diff             @@
##             v3.x    #2124      +/-   ##
==========================================
+ Coverage   60.34%   60.74%   +0.39%     
==========================================
  Files         915      915              
  Lines        9450     9379      -71     
  Branches     1890     1885       -5     
==========================================
- Hits         5703     5697       -6     
+ Misses       3314     3249      -65     
  Partials      433      433              
Flag Coverage Δ
addon-charts 74.44% <ø> (+0.47%) ⬆️
addon-doc 20.95% <ø> (ø)
addon-editor 46.28% <ø> (+0.17%) ⬆️
addon-mobile ∅ <ø> (∅)
addon-table 83.78% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 66.60% <60.00%> (+0.57%) ⬆️
core 67.20% <100.00%> (+0.04%) ⬆️
kit 59.35% <0.00%> (+0.60%) ⬆️
summary 60.74% <53.84%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...input-card-grouped/input-card-grouped.component.ts 61.60% <ø> (+0.48%) ⬆️
...ts/input-card-grouped/input-card-grouped.module.ts 100.00% <ø> (ø)
...erce/components/input-card/input-card.component.ts 67.56% <ø> (+1.77%) ⬆️
...mmerce/components/input-cvc/input-cvc.component.ts 61.11% <ø> (+3.21%) ⬆️
.../components/input-expire/input-expire.component.ts 65.00% <ø> (+3.09%) ⬆️
...or/components/input-color/input-color.component.ts 73.68% <ø> (+7.01%) ⬆️
...rojects/core/components/button/button.component.ts 80.00% <ø> (+4.00%) ⬆️
...imitive-textfield/primitive-textfield.component.ts 74.64% <ø> (+1.03%) ⬆️
.../primitive-textfield/primitive-textfield.module.ts 100.00% <ø> (ø)
projects/kit/abstract/input-slider.ts 77.41% <ø> (+2.41%) ⬆️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c1c7f1...6f3ba04. Read the comment docs.

@tinkoff-bot tinkoff-bot force-pushed the interactive_deprecated branch from aa11775 to 6f3ba04 Compare July 15, 2022 08:59
@vladimirpotekhin vladimirpotekhin merged commit 143e3d0 into v3.x Jul 15, 2022
@vladimirpotekhin vladimirpotekhin deleted the interactive_deprecated branch July 15, 2022 10:26
@well-done-bot
Copy link

well-done-bot bot commented Jul 15, 2022

'Well done'

This was referenced Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants