Skip to content

MLP model #829

Closed
martins0n opened this issue Aug 1, 2022 · 0 comments · Fixed by #860
Closed

MLP model #829

martins0n opened this issue Aug 1, 2022 · 0 comments · Fixed by #860
Assignees
Labels
enhancement New feature or request

Comments

@martins0n
Copy link
Contributor

martins0n commented Aug 1, 2022

🚀 Feature Request

Add MLPModel model for etna deep model family

Proposal

class MLPNet(DeepBaseNet):
    def __init__(
        self,
        input_size: int,
        hidden_size: List[int],
        lr: float,
        loss: "torch.nn.Module",
        optimizer_params: Optional[dict],
    ) -> None:
   pass
  • For MLP we dont need encoder part: so encoder_lenght=0
  • Typical batch sample would have shape [encoder_lenght, input_size]

Test cases

  • add unit tests for make_sample
  • add seasonal overfit test
  • add test for step and retrun values
  • add test for forward and return values

Additional context

No response

@martins0n martins0n added the enhancement New feature or request label Aug 1, 2022
@martins0n martins0n moved this to Specification in etna board Aug 1, 2022
@alex-hse-repository alex-hse-repository moved this from Specification to Todo in etna board Aug 2, 2022
@DBcreator DBcreator self-assigned this Aug 3, 2022
@alex-hse-repository alex-hse-repository moved this from Todo to In Progress in etna board Aug 4, 2022
@DBcreator DBcreator mentioned this issue Aug 17, 2022
4 tasks
@martins0n martins0n moved this from In Progress to In Review in etna board Aug 18, 2022
Repository owner moved this from In Review to Done in etna board Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants