Skip to content

Make TimeSeriesImputerTransform vectorized #1287

Closed
Mr-Geekman opened this issue Jun 14, 2023 · 0 comments · Fixed by #1293
Closed

Make TimeSeriesImputerTransform vectorized #1287

Mr-Geekman opened this issue Jun 14, 2023 · 0 comments · Fixed by #1293
Assignees
@Mr-Geekman
Labels
enhancement New feature or request priority/medium Medium priority task

Comments

@Mr-Geekman
Copy link
Contributor

🚀 Feature Request

In current version TimeSeriesImputerTransform is inherited from PerSegmentWrapper. It leads to for-loop in iteration by segments. We can possible implement it more efficiently.

Proposal

Implement TimeSeriesImputerTransform to work without PerSegmentWrapper. There was an unfinished prototype for this task: #760.

Test cases

  • Fix tests to work with TimeSeriesImputerTransform, not with it one-segment version.
  • Make sure current tests pass.

Additional context

Related to #1015.
@Mr-Geekman Mr-Geekman added enhancement New feature or request priority/medium Medium priority task labels Jun 14, 2023
@github-project-automation github-project-automation bot moved this to Specification in etna board Jun 14, 2023
@Mr-Geekman Mr-Geekman moved this from Specification to Todo in etna board Jun 15, 2023
@Mr-Geekman Mr-Geekman self-assigned this Jun 21, 2023
@Mr-Geekman Mr-Geekman moved this from Todo to In Progress in etna board Jun 21, 2023
@Mr-Geekman Mr-Geekman mentioned this issue Jun 21, 2023
Merged
4 tasks
@Mr-Geekman Mr-Geekman moved this from In Progress to In Review in etna board Jun 21, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in etna board Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mr-Geekman Mr-Geekman

Labels
enhancement New feature or request priority/medium Medium priority task
Projects
etna board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite TimeSeriesImputerTransform to work without per-segment wrapper tinkoff-ai/etna
1 participant
@Mr-Geekman