Skip to content

[BUG] Dangerous behavior of HierarchicalPipeline during interval prediction #1257

Closed
1 task done
Mr-Geekman opened this issue May 3, 2023 · 0 comments · Fixed by #1259
Closed
1 task done

[BUG] Dangerous behavior of HierarchicalPipeline during interval prediction #1257

Mr-Geekman opened this issue May 3, 2023 · 0 comments · Fixed by #1259
Assignees
@Mr-Geekman
Labels
bug Something isn't working

Comments

@Mr-Geekman
Copy link
Contributor

Mr-Geekman commented May 3, 2023 •
edited
Loading

🐛 Bug Report

In HierarchicalPipeline during interval prediction we have this code. For example, if something breaks before we change methods back, they will stay swapped, and it can lead to very strange behavior.

Expected behavior

User can't see the behavior with swapped methods.

It can probably be fixed with try/finally clause with reraising exception after switching methods back.

How To Reproduce

.

Environment

No response

Additional context

No response

Checklist

  • Bug appears at the latest library version
@Mr-Geekman Mr-Geekman added the bug Something isn't working label May 3, 2023
@github-project-automation github-project-automation bot moved this to Specification in etna board May 3, 2023
@Mr-Geekman Mr-Geekman moved this from Specification to Todo in etna board May 4, 2023
@Mr-Geekman Mr-Geekman self-assigned this May 5, 2023
@Mr-Geekman Mr-Geekman removed the status in etna board May 5, 2023
@Mr-Geekman Mr-Geekman moved this to In Progress in etna board May 5, 2023
@Mr-Geekman Mr-Geekman mentioned this issue May 5, 2023
Merged
4 tasks
@Mr-Geekman Mr-Geekman moved this from In Progress to In Review in etna board May 5, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in etna board May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mr-Geekman Mr-Geekman

Labels
bug Something isn't working
Projects
etna board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix problem with swapped forecast methods in HierarchicalPipeline tinkoff-ai/etna
1 participant
@Mr-Geekman