Skip to content

Make backtest work with pipeline #121

Closed
3 tasks done
iKintosh opened this issue Sep 30, 2021 · 1 comment · Fixed by #161
Closed
3 tasks done

Make backtest work with pipeline #121

iKintosh opened this issue Sep 30, 2021 · 1 comment · Fixed by #161
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@iKintosh
Copy link
Contributor

iKintosh commented Sep 30, 2021

🚀 Feature Request

Backtest should work with pipeline not bare model. It makes backtest easier as a class.

Motivation

Backtest implements logic that are now a part of Pipeline class.

Proposal

--

Test cases

No response

Alternatives

No response

Additional context

No response

Checklist

  • Added feature request
  • Added motivation
  • Added proposal
@iKintosh iKintosh added enhancement New feature or request help wanted Extra attention is needed labels Sep 30, 2021
@martins0n
Copy link
Contributor

Proposal:
We shoud just add backtest method to BasePipeline.
ToBe:

class BasePipeline:
    def __init__(self, horizon, *args, **kwargs):
          pass
    def fit(self, ts):
          pass
    def forecast(self):
          pass
    def backtest(self, ts: TSDataset, metrics: List[Metric], n_folds: int = 5, mode: str = "expand", n_jobs: int = 1):
          pass

In the next series we should remove TimeSeriesCrossvalidation

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants