Skip to content

Implement forecast decomposition for Holt-like models #1146

Closed
alex-hse-repository opened this issue Mar 3, 2023 · 0 comments · Fixed by #1162
Closed

Implement forecast decomposition for Holt-like models #1146

alex-hse-repository opened this issue Mar 3, 2023 · 0 comments · Fixed by #1162
Assignees
Labels
enhancement New feature or request

Comments

@alex-hse-repository
Copy link
Collaborator

alex-hse-repository commented Mar 3, 2023

🚀 Feature Request

Implement forecast decomposition for models from holt_winters.py

Proposal

In _HoltWintersAdapter implement method

def predict_components(df: pd.DataFrame) -> pd.DataFrame
def forecast_components(df: pd.DataFrame) -> pd.DataFrame

Details:

  • implement in-sample decomposition in predict_components
  • implement out-of-sample decomposition in forecast_components
  • use model fit results to obtain level, trend and seasonal components for training set
  • for forecast use componetns from train to estimate corresponding decomposition
  • use target_component_ as prefix for component names
  • raise error for multiplicative models
  • if use_boxcox for HoltWintersModel is on, do the inverse transformation for components like in inverse_transform method of our Transforms

Test cases

For models from holt_winters.py

  • Test components sum up to target for different parameter sets
  • Test damped trend for HoltWintersModel and HoltModel
  • Test that the component names are correct for all possible parameters combination
  • Test components transformed along with target when use_boxcox set in HoltWintersModel
  • Test that model decomposition contains only additive components and raises corresponding error otherwise

Additional context

Models reference

See implementation in ETNA-1480 folder

@alex-hse-repository alex-hse-repository added the enhancement New feature or request label Mar 3, 2023
@github-project-automation github-project-automation bot moved this to Specification in etna board Mar 3, 2023
@brsnw250 brsnw250 changed the title Implement forecast decomposition for Hotl-like models Implement forecast decomposition for Holt-like models Mar 3, 2023
@brsnw250 brsnw250 self-assigned this Mar 10, 2023
@brsnw250 brsnw250 moved this from Specification to In Progress in etna board Mar 10, 2023
@alex-hse-repository alex-hse-repository moved this from In Progress to In Review in etna board Mar 14, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in etna board Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants