Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prettier is required by kube.mk #578

Open
displague opened this issue Jan 12, 2022 · 2 comments
Open

prettier is required by kube.mk #578

displague opened this issue Jan 12, 2022 · 2 comments
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@displague
Copy link
Member

prettier is required by kube.mk, preventing make generate from succeeding when prettier is not installed.

Expected Behaviour

Most of the required tools for linting and code generation are installed as needed. Prettier should be automatically installed.

Current Behaviour

make generate failed if it is not installed.

Possible Solution

Add a prettier task to one of the Makefiles. Depend on this task for generate-manifests.

Steps to Reproduce (for bugs)

Context

Your Environment

  • Operating System and version (e.g. Linux, Windows, MacOS):

  • How are you running Tinkerbell? Using Vagrant & VirtualBox, Vagrant & Libvirt, on Packet using Terraform, or give details:

  • Link to your project or a code example to reproduce issue:

@chrisdoherty4 chrisdoherty4 added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Jun 14, 2022
@chrisdoherty4
Copy link
Member

chrisdoherty4 commented Nov 12, 2022

It seems like the intent is for people to use NixOS so it should be available. NixOS is painful and we've talked about getting rid of it entirely. Since the files being 'prettified' are generated, I've opted for a simple life and just removed prettier in #650 as I couldn't get past the CI checks without setting up and understanding in some capacity NixOS, which I don't want to do.

@chrisdoherty4 chrisdoherty4 self-assigned this Nov 12, 2022
@chrisdoherty4 chrisdoherty4 removed their assignment Nov 21, 2022
@chrisdoherty4
Copy link
Member

chrisdoherty4 commented Nov 21, 2022

Due to other issues I had to revert removing prettier. Lets move to get rid of it soon, particularly for generated files.

Once removed we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

2 participants