Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for public registries #303

Closed
displague opened this issue Sep 21, 2020 · 6 comments
Closed

Add support for public registries #303

displague opened this issue Sep 21, 2020 · 6 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@displague
Copy link
Member

Currently, docker registry username, password, and host values must be provided throughout the Tinkerbell ecosystem.

While authenticated Docker registries are practical for production deployments, in development and home lab environments this additional configuration and requirement creates a burden and restricts use.

By making these registry arguments optional, we enable:

  • local registries without authentication (such as the kind-local registry)
  • running workflows using upstream images directly

This may require changes to boots, tink-worker, and perhaps others. This issue only reflects the tink-worker changes.

Originally posted by @detiber in #287 (comment)

@displague displague added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 21, 2020
@displague
Copy link
Member Author

@gianarb
Copy link
Contributor

gianarb commented Sep 22, 2020

This is in some way related to #134 and #90 . Community is asking for both. Give us a secure environment and remote passwords.

Consistency is the only takeaway here

@detiber
Copy link
Contributor

detiber commented Sep 22, 2020

@gianarb I think it might be tangentially related.

Ideally we'd support working with an existing registry host more easily, which is what this would be targeting. Ideally if we do deploy a registry it should be secure, but if a user already has a registry (or wants to use a public registry), then we should allow for it to be used and not necessarily require authentication for pulls.

@tstromberg tstromberg added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Aug 27, 2021
@jacobweinstock
Copy link
Member

FYI, this ticket and others that are similar have been captured in this discussion #586

@mmlb
Copy link
Contributor

mmlb commented Apr 18, 2022

#607 touches on this a little bit

@jacobweinstock
Copy link
Member

close by #607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

6 participants