Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image2disk workflow swallows errors #39

Closed
moadqassem opened this issue Apr 12, 2021 · 1 comment · Fixed by #40
Closed

Image2disk workflow swallows errors #39

moadqassem opened this issue Apr 12, 2021 · 1 comment · Fixed by #40

Comments

@moadqassem
Copy link
Member

image2disk workflow swallows some of the errors which are returned once the workflow is executed.

Expected Behaviour

When an error occurs, it should be printed out in the logs

Current Behaviour

No error is being printed out.

Possible Solution

Add the errors in the fmt.Errorf() function

Steps to Reproduce (for bugs)

1.Run the workflow
2.If an error has been encountered during partitions re-probing, error message won't be there
3.
4.

Context

Your Environment

  • Operating System and version (e.g. Linux, Windows, MacOS):
    OSIE
  • How are you running Tinkerbell? Using Vagrant & VirtualBox, Vagrant & Libvirt, on Packet using Terraform, or give details:
    OnPrem
  • Link to your project or a code example to reproduce issue:
@moadqassem
Copy link
Member Author

FYI, here is the PR for the fix #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant