Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tinderauth #98

Closed
run1t opened this issue Apr 21, 2016 · 3 comments
Closed

Use tinderauth #98

run1t opened this issue Apr 21, 2016 · 3 comments

Comments

@run1t
Copy link
Member

run1t commented Apr 21, 2016

It could be a good improvement to use the tinderauth repo to get the tokens, as is we don't have to login every times and can integrate the login form directly in the main window.

@mayeaux
Copy link
Member

mayeaux commented Apr 21, 2016

Yeah, we could store the username and password as well. One thing to note is that tinderauth takes a while to run because ZombieJS is so slow, and it isn't super tested either, I'm not sure it's super robust

@stuwil
Copy link
Contributor

stuwil commented Apr 22, 2016

Hey guys,

I'd strongly urge against doing this. We should let Facebook handle user credentials... a few reasons:

  1. In general, asking users for credentials to another application is super sketch, which is one of the reasons everyone uses OAuth.
  2. We have nowhere we can safely store the password, and the burden/liability of managing passwords for another app isn't something we should be dealing with.
  3. 2FA enabled on a Facebook account means the user would have to enter their token in the window anyways. This isn't just a technical problem, as anyone who has 2FA enabled probably wouldn't put their FB credentials directly into our app anyways - see point 1.

Check out #91, which fixes some issues, including constantly getting prompted for your password from Facebook. We can take advantage of the existing Facebook session (if the user opted to remember the computer) to generate Tinder tokens as needed.

@mayeaux
Copy link
Member

mayeaux commented Apr 26, 2016

Yeah agreed, let's not even open that can of worms, if we fix the issue where we're logged out all the time we should be absolutely fine, those xAuthTokens that Tinder gives back are pretty hardy and can be used for quite a while.

@mayeaux mayeaux closed this as completed Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants