Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SnoopCompileBot deprecations notice #99

Closed
aminya opened this issue Jun 17, 2020 · 5 comments · Fixed by #127
Closed

SnoopCompileBot deprecations notice #99

aminya opened this issue Jun 17, 2020 · 5 comments · Fixed by #127

Comments

@aminya
Copy link
Contributor

aminya commented Jun 17, 2020

Some packages are using .github/workflows/SnoopCompile.yml, and inside that, they add SnoopCompile and use it. Is there a way that CompatHelper allows us to find these packages and give them some notification that SnoopCompile is updated and they might need to update some of their code?

Deprecation warnings are just shown passed in GitHub actions and the users may not notice anything.

One solution might be using CompatHelper:
JuliaRegistries/CompatHelper.jl#218

@timholy
Copy link
Owner

timholy commented Jun 22, 2020

I guess the risk is they might not check the logs? I think it's on them 😄.

@aminya
Copy link
Contributor Author

aminya commented Jun 22, 2020

Part of it is that not very often people read CI log (unless it errors), and that is why we need to have a better way to inform them. My Julia issue was closed, but @christopher-dG mentioned that he can make a new package, that gives us the ability to push the warnings to GitHub's warning system.

@christopher-dG
Copy link

The actual code is basically done, just needs some grunt work https://github.com/julia-actions/GitHubActions.jl

@aminya
Copy link
Contributor Author

aminya commented Jun 22, 2020

@christopher-dG That is awesome. Could we rename this package to CILogger instead, and implement different styles of logging for different services all in one package? We can add more services like Travis, Azure, etc.

@christopher-dG
Copy link

No, this one is going to be just GitHub Actions (it does more than logging). You could make a meta-package of sorts that aggregates various similar packages if you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants