Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxdepth option #111

Open
oxinabox opened this issue Apr 16, 2019 · 5 comments
Open

maxdepth option #111

oxinabox opened this issue Apr 16, 2019 · 5 comments
Labels
wishlist Feature requests

Comments

@oxinabox
Copy link

On manythings I want to profile,
running ProfileView kills my computer.
Because it makes like a billion SVGs.

Profile.print takes a maxdepth kwarg.
That would be useful to have for ProfileView.view as well

@timholy
Copy link
Owner

timholy commented Apr 17, 2019

Does that happen if you use the Gtk interface? I've not had that problem. Because I don't know the web side, I can't really maintain that, I depend on outside contributors.

@oxinabox
Copy link
Author

Yes, GTK and SVG both do it.
Though I've never had GTK not freeze. (but I've also never had less than billions of things to show)
so maybe my GTK death is unrelated

@timholy
Copy link
Owner

timholy commented Apr 17, 2019

Interesting. Can you give me a reproducible example? I'd rather not make success (or lack of crash) dependent on the user knowing to supply a particular kwarg.

@timholy timholy added the wishlist Feature requests label Dec 8, 2019
@timholy
Copy link
Owner

timholy commented Jan 22, 2020

If your calls are recursive, on Julia 1.4+ you can try the recur keyword.

@kimikage
Copy link

FYI, the maxdepth option is now supported in ProfileSVG, which was separated from this package.
https://kimikage.github.io/ProfileSVG.jl/v0.2/other-options/#maxdepth-and-maxframes

I don't know whether the GTK-based GUI still needs the maxdepth option.
cc: @oxinabox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wishlist Feature requests
Projects
None yet
Development

No branches or pull requests

3 participants