-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How does the package compare to Requires.jl? #14
Comments
This package is really about choosing which resource you want for a specific computation. In ImageFiltering you can run With regards to loading "glue" code I would switch to Requires. The mechanism documented here was reliable back in an era when Requires was pretty hacky (it did some crazy stuff), but Requires has become a better citizen and it's now better to use it. A PR to change the README would be most appreciated! |
Thank you, my short-term plan is to use Requires.jl to load both OpenCL.jl and CLFFT.jl as dependencies and load the related code in ImageQuilting.jl. In the long-term, however, I would like to migrate the OpenCL imfilter implementation I have there to ImageFiltering.jl, and use ComputationalResources.jl to dispatch it: https://github.com/juliohm/ImageQuilting.jl/blob/master/src/imfilter_gpu.jl Does it sound like a reasonable way forward? |
That's precisely how it should work 😄. Great plan. |
Closing this one as the plan is clear 👍 |
Hi Tim,
I appreciate if you can clarify the mechanism of this package as compared to Requires.jl? I am trying to upgrade ImageQuilting.jl to Julia v0.7, and I will have to make OpenCL + CLFFT optional dependencies. As far as I understood the
addresource
command in this package plays the role of a "priority queue" of resources where GPUs have higher priority than CPUs? I wonder what is your recommendation for upgrading code in the long-term?Thank you,
The text was updated successfully, but these errors were encountered: