-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pgx 0.6.1 with PostgreSQL 15 support #646
Conversation
Current status: this passes on CI up to the point where it tries to run doc-tests, which fail since I removed TimescaleDB from the Docker image, since TimescaleDB doesn't support pg15 yet. |
adefeb9
to
8feba03
Compare
The CI now passes on this branch, although we don't run doc/upgrade tests for pg15 yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
b33e307
to
41ae514
Compare
Updated the PR to pgx 0.6.1, released 2 hours ago. The CI still passes when run with the Docker image from this branch. |
Signed-off-by: Smittyvb <[email protected]>
I rebased and updated the changelog entry to indicate that PostgreSQL 15 support is experimental. I ran the CI again, it still passes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, hang on, what's wrong with Clippy?
I think the new pgx is using a feature that was stabilized in Rust 1.63 which our older (1.60?) clippy still thinks is unstable. |
The error with Clippy happens when you try to compile pgx with rustc < 1.63, since rustc 1.63 stabilized a library feature that pgx relies on:
This PR updates the Docker image to rustc 1.63 which stabilizes the needed feature. (which is why the CI passes on the Docker image built from this branch) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course. When Brian approves this, you can publish the image from this branch and then the checks will clear? Thanks!
Signed-off-by: Smittyvb <[email protected]>
bors r+ |
Build succeeded: |
No description provided.