Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pgx 0.6.1 with PostgreSQL 15 support #646

Merged
merged 9 commits into from
Dec 13, 2022
Merged

Use pgx 0.6.1 with PostgreSQL 15 support #646

merged 9 commits into from
Dec 13, 2022

Conversation

syvb
Copy link
Member

@syvb syvb commented Dec 1, 2022

No description provided.

@syvb
Copy link
Member Author

syvb commented Dec 1, 2022

Current status: this passes on CI up to the point where it tries to run doc-tests, which fail since I removed TimescaleDB from the Docker image, since TimescaleDB doesn't support pg15 yet.

@syvb syvb force-pushed the sv/pgx-next branch 4 times, most recently from adefeb9 to 8feba03 Compare December 1, 2022 22:16
@syvb
Copy link
Member Author

syvb commented Dec 1, 2022

The CI now passes on this branch, although we don't run doc/upgrade tests for pg15 yet.

@syvb syvb marked this pull request as ready for review December 2, 2022 14:00
Copy link
Contributor

@epgts epgts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@syvb syvb force-pushed the sv/pgx-next branch 2 times, most recently from b33e307 to 41ae514 Compare December 5, 2022 17:41
@syvb syvb changed the title Use pgx 0.6.0 with PostgreSQL 15 support Use pgx 0.6.1 with PostgreSQL 15 support Dec 6, 2022
@syvb
Copy link
Member Author

syvb commented Dec 6, 2022

Updated the PR to pgx 0.6.1, released 2 hours ago. The CI still passes when run with the Docker image from this branch.

@syvb
Copy link
Member Author

syvb commented Dec 12, 2022

I rebased and updated the changelog entry to indicate that PostgreSQL 15 support is experimental. I ran the CI again, it still passes.

@syvb syvb requested a review from epgts December 12, 2022 20:09
Copy link
Contributor

@epgts epgts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, hang on, what's wrong with Clippy?

@rtwalker
Copy link
Contributor

rtwalker commented Dec 12, 2022

Actually, hang on, what's wrong with Clippy?

I think the new pgx is using a feature that was stabilized in Rust 1.63 which our older (1.60?) clippy still thinks is unstable.

@syvb
Copy link
Member Author

syvb commented Dec 12, 2022

The error with Clippy happens when you try to compile pgx with rustc < 1.63, since rustc 1.63 stabilized a library feature that pgx relies on:

error[E0658]: use of unstable library feature 'slice_ptr_len'
  --> /usr/local/cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/pgx-0.6.1/src/slice.rs:28:32
   |
28 |         index.le(&self.pallocd.len()).then(|| self.get_unchecked(index))
   |                                ^^^
   |
   = note: see issue #71146 <https://github.com/rust-lang/rust/issues/71146> for more information

This PR updates the Docker image to rustc 1.63 which stabilizes the needed feature. (which is why the CI passes on the Docker image built from this branch)

Copy link
Contributor

@epgts epgts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course. When Brian approves this, you can publish the image from this branch and then the checks will clear? Thanks!

@syvb
Copy link
Member Author

syvb commented Dec 13, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 13, 2022

@bors bors bot merged commit bfd1adc into main Dec 13, 2022
@bors bors bot deleted the sv/pgx-next branch December 13, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants