Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

Add HTTP HEAD support to health check endpoint #710

Closed
caseyandgina opened this issue Jul 28, 2021 · 4 comments
Closed

Add HTTP HEAD support to health check endpoint #710

caseyandgina opened this issue Jul 28, 2021 · 4 comments
Labels
Improvement Improvements to the existing features

Comments

@caseyandgina
Copy link

Our infrastructure guys asked if it might be possible for HTTP HEAD support to be added to the health check endpoint, as this would result in less work for the load balancers to have to do as they only care about the status code? Currently using GET is required.

$ curl -I http://d-gp2-dbapromscale-1.imovetv.com:9201/healthz
HTTP/1.1 405 Method Not Allowed
Allow: GET, OPTIONS
Content-Type: text/plain; charset=utf-8
X-Content-Type-Options: nosniff
Date: Wed, 28 Jul 2021 19:24:13 GMT
Content-Length: 19

$ curl -s -o /dev/null -w "%{http_code}" http://d-gp2-dbapromscale-1.imovetv.com:9201/healthz
200
@Harkishen-Singh
Copy link
Member

Harkishen-Singh commented Aug 2, 2021

@cevian lets have this as part of our next (or sometime around that) release.

I think this will require a change in "github.com/prometheus/common/route" to allow .Head() funcs, which should be a simple one liner addition.

@Harkishen-Singh Harkishen-Singh added the Improvement Improvements to the existing features label Aug 2, 2021
@paulfantom
Copy link
Contributor

Change upstream is complete. We can either use github.com/prometheus/common@5a265357 or wait for next release (possibly 0.32.0) of that package and bump our go.mod

@VineethReddy02
Copy link
Contributor

@niksajakovljevic can we close this issue wrt #1378 ?

@niksajakovljevic
Copy link
Contributor

Fixed with #1378

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Improvement Improvements to the existing features
Projects
None yet
Development

No branches or pull requests

5 participants