kaizen: Increase throughput with flexible FA traversal #332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We took a ~20% performance penalty with the introduction of NFAs (and thus full shellstyle support) and this is shown up particularly in numeric patterns. It turns out that while our data structure is designed to support NFAs, a lot of the FAs we generate are actually deterministic, i.e the combination of a state and a byte always causes a transfer to zero or one other state. Thus it is possible to traverse the FA without keeping track of multiple current/next states, vastly reducing the amount of memory management required. This PR led to ~20% performance improvement on common cases, no change on shellstyle, probably >20% on numerically-heavy patterns. 20% is pretty good since half our CPU/elapsed time still goes into flattening the events.