Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pat: Add full suite of numeric expressions #324

Open
timbray opened this issue Jun 27, 2024 · 2 comments
Open

pat: Add full suite of numeric expressions #324

timbray opened this issue Jun 27, 2024 · 2 comments

Comments

@timbray
Copy link
Owner

timbray commented Jun 27, 2024

Issue #27 is just arranging that pattern

{"x": [ 35 ]}

Will match both of the following:

{"x": 35.0}
{"x": 3.5e1}

This new issue calls for the full suite of arithmetic expressions supported by event-ruler, for example:

{"x": [ { "numeric": [ ">", 0, "<=", 5 ] } ] }
@sathishdv
Copy link
Collaborator

@timbray Any plans of including numeric expressions sooner?

@timbray
Copy link
Owner Author

timbray commented Jan 22, 2025

I've been focused for a few weeks on implementing regular expressions, which turns out to be quite difficult. I predict that it's another month before I'm happy with the progress and ready to turn to something else.

Note that there is a full implementation of numeric expressions in aws/event-ruler and I think its design is basically OK, so if someone else wanted to pick up this work it would be a porting task not requiring algorithm invention, and (very important) there is a full set of unit tests for free that you just have to translate from Java to Go.

Having said all that, when I stop working on regular expressions I guess numeric expressions would be the next target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants