Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate or update react-app-rewire-relay? #255

Closed
orta opened this issue Jun 10, 2018 · 2 comments
Closed

Deprecate or update react-app-rewire-relay? #255

orta opened this issue Jun 10, 2018 · 2 comments

Comments

@orta
Copy link

orta commented Jun 10, 2018

Hey there, it might be worth either deprecating this package or bringing it up to date by making it use injectBabelPlugin?

In my app, I replaced it with the usage of injectBabelPlugin to look like this in the config:

const {
  rewireWebpack: rewireTypescript,
  rewireJest: rewireTypescriptJest,
} = require("react-app-rewire-typescript-babel-preset")
const { injectBabelPlugin } = require("react-app-rewired")

module.exports = {
  webpack: function(config, env) {
    let webpack = rewireTypescript(config)
    webpack = injectBabelPlugin("relay", webpack)
    return webpack
  },
  jest: function(config) {
    let jest = rewireTypescriptJest(config)
    jest = injectBabelPlugin("relay", webpack)
    return jest
  },
}

If you have opinions either way, I'm happy to take a look at doing that.

@timarney
Copy link
Owner

I would be for deprecating and maintaining outside of the main repo. To me continuing down the path of community maintained rewires makes the most sense.

https://github.com/timarney/react-app-rewired#community-maintained-rewires

@timarney
Copy link
Owner

Closing this feel free to make an external repo and we'll like to it + likely deprecate the other (when it makes sense to do so)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants