Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offload periodic work #328

Merged
merged 4 commits into from
Jan 31, 2023
Merged

offload periodic work #328

merged 4 commits into from
Jan 31, 2023

Conversation

tabokie
Copy link
Member

@tabokie tabokie commented Jan 28, 2023

Signed-off-by: tabokie [email protected]

Signed-off-by: tabokie <[email protected]>
@tabokie tabokie requested review from BusyJay and Connor1996 January 28, 2023 06:52
Copy link
Member

@BusyJay BusyJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you describe the purpose and also send the patch to upstream?

Signed-off-by: tabokie <[email protected]>
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's it for?

@tabokie
Copy link
Member Author

tabokie commented Jan 29, 2023

What's it for?

It's a waste to schedule work for each instance because the statistics and logger is shared.

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: tabokie <[email protected]>
Signed-off-by: tabokie <[email protected]>
@tabokie tabokie merged commit 2cbb069 into tikv:6.29.tikv Jan 31, 2023
@tabokie tabokie deleted the periodic-work branch January 31, 2023 06:49
tabokie added a commit to tabokie/rocksdb that referenced this pull request Feb 1, 2023
This reverts commit 2cbb069.

Signed-off-by: tabokie <[email protected]>
tabokie added a commit that referenced this pull request Feb 2, 2023
This reverts commit 2cbb069.

Signed-off-by: tabokie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants