Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service Safepoint with infinite TTL may disappear #3128

Closed
MyonKeminta opened this issue Nov 2, 2020 · 0 comments · Fixed by #3138
Closed

Service Safepoint with infinite TTL may disappear #3128

MyonKeminta opened this issue Nov 2, 2020 · 0 comments · Fixed by #3138
Labels
severity/major type/bug The issue is confirmed as a bug.

Comments

@MyonKeminta
Copy link
Contributor

MyonKeminta commented Nov 2, 2020 •
edited
Loading

Bug Report

What did you do?

(Still not confirmed what operation triggered the problem)

What did you expect to see?

The service safepoint set by TiDB (with id "gc_worker") should last forever, because it's TTL should be infinite.

What did you see instead?

The service safepoint whose id is "gc_worker" disappears. If there's another service trying to register service safepoint, this may cause the min service safepoint to regress.

What version of PD are you using (pd-server -V)?

master (d043072)
@MyonKeminta MyonKeminta added the type/bug The issue is confirmed as a bug. label Nov 2, 2020
@zier-one zier-one mentioned this issue Nov 2, 2020
Merged
@MyonKeminta MyonKeminta mentioned this issue Nov 2, 2020
Merged
@ti-srebot ti-srebot mentioned this issue Nov 3, 2020
Merged
@ti-srebot ti-srebot mentioned this issue Nov 19, 2020
Merged
@lichunzhu lichunzhu mentioned this issue Jan 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

server: Fix the bug that infinite TTL for service safepoint doesn't work MyonKeminta/pd
2 participants
@jebter @MyonKeminta