Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Revert to Laravel namespace? #105

Closed
Isinlor opened this issue May 10, 2018 · 1 comment
Closed

Revert to Laravel namespace? #105

Isinlor opened this issue May 10, 2018 · 1 comment

Comments

@Isinlor
Copy link

Isinlor commented May 10, 2018

It's not an official Laravel package so we don't want to use the Packagist namespace reserved by Laravel packages. One day Collection may be extracted from illuminate/support to a new package. If so, we'll deprecate this package and point to the core version.

The issues seem like pretty good reason to ignore courtesy and go with Laravel namespace.
#104
#90

Was there any technical reason to change namespace?

Packagist should be fine with package named NotLaravel/Collection delivering classes from Laravel namespace. I would also expect php/composer autoloader to handle loading of classes duplicate in multiple files without issues. Either of them would be loaded first and the other ignored.

The only issue should be keeping 100% consistency with Laravel versioning.

@mattstauffer
Copy link
Member

#54

See this issue and its corresponding PRs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants