Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters: align with Autoware Foundation proposal for ROS nodes #63

Closed
drwnz opened this issue Aug 29, 2023 · 0 comments
Closed

Parameters: align with Autoware Foundation proposal for ROS nodes #63

drwnz opened this issue Aug 29, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@drwnz
Copy link
Collaborator

drwnz commented Aug 29, 2023

Within the Autoware Foundation, there is a proposal to mandate a schema to describe the parameters of each ROS node.
Nebula, as part of the Autoware project, should ideally follow this structure.

https://github.com/orgs/autowarefoundation/discussions/3371

See also:
https://autowarefoundation.github.io/autoware-documentation/main/contributing/coding-guidelines/ros-nodes/parameters/

This requires:

  • Removal of default_value in all declare_parameter() instances
  • Create a *.param.yaml and *.schema.json file for each decoder, hardware interface, and hardware monitor
    • This may require care when some sensors do not make use of all parameters of a particular node
  • CI configuration?
@drwnz drwnz added the enhancement New feature or request label Aug 29, 2023
@drwnz drwnz closed this as completed Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants