Use ggdist::ramp_colours in ggdist > 3.3.1 #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mitchelloharawild pinging again --- I'd like to do a CRAN submission soon on this, ideally in the next week, because I don't want to leave some parts of {ggdist} not working properly in the CRAN version. When that happens I believe some {fabletools} tests will break on CRAN unless this issue is fixed. |
|
Thanks for the bump, I'll prepare a CRAN patch asap. |
|
Thanks much! |
mitchelloharawild
added a commit
that referenced
this pull request
Mar 2, 2024
|
On CRAN now 🎉 |
|
Sweet, thanks for the quick response! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mitchelloharawild --- I am preparing to make a new release of {ggdist} this week, partly to fix some minor issues due to the new release of {ggplot2}. During revdep checks I found a minor issue in {fabletools}.
As I am sure you discovered, colour ramps produced by {ggdist} were previously just a list type with attributes, and the method for applying them was not exported. The new version of {ggdist} now uses a proper datatype to represent partial colour ramps produced by the
colour_rampandfill_rampscales, and exports a function,ggdist::ramp_colours(), for applying them. As a result, the old approach for translating colour ramps into colour no longer works and needs to be updated here, which this PR does.