Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression in guide_bins(reverse) #6185

Merged
merged 6 commits into from
Jan 27, 2025
Merged

Fix regression in guide_bins(reverse) #6185

merged 6 commits into from
Jan 27, 2025
+119 −2

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix #6183.

It relies on the fix in #4442 that I suspect got looked past when refactoring the guide system.

thomasp85
thomasp85 approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand
Copy link
Collaborator Author

I'm sneaking in a small fix for #5912 that used the old check_subclass() that got replaced by #6072's validate_subclass().

@teunbrand teunbrand merged commit a62895a into tidyverse:main Jan 27, 2025
13 checks passed
@teunbrand teunbrand deleted the guide_bins_reverse branch January 27, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Top key missing in guide_bins when reverse = TRUE
2 participants
@teunbrand @thomasp85