Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial ungroup() is broken #6606

Closed
DavisVaughan opened this issue Dec 14, 2022 · 0 comments · Fixed by #6607
Closed

Partial ungroup() is broken #6606

DavisVaughan opened this issue Dec 14, 2022 · 0 comments · Fixed by #6607
Assignees
Labels
bug an unexpected problem or unintended behavior
Milestone

Comments

@DavisVaughan
Copy link
Member

In #6355, accidentally broken when moving from vars_select() to eval_select(), because vars_select() returns a character vector and eval_select() returns an integer vector

7c28098#diff-1ec33e14b938e61e20e0bef01b54aa084a603bfcbf3449c84535293f0f6ca9a5R154

Breaks MetAlyzer, found in #6262.

library(dplyr)

df <- tibble(g = 1)
gdf <- group_by(df, g)

gdf
#> # A tibble: 1 × 1
#> # Groups:   g [1]
#>       g
#>   <dbl>
#> 1     1

# Should ungroup by `g`
ungroup(gdf, g)
#> # A tibble: 1 × 1
#> # Groups:   g [1]
#>       g
#>   <dbl>
#> 1     1

Created on 2022-12-14 with reprex v2.0.2.9000

@DavisVaughan DavisVaughan added the bug an unexpected problem or unintended behavior label Dec 14, 2022
@DavisVaughan DavisVaughan self-assigned this Dec 14, 2022
@DavisVaughan DavisVaughan added this to the 1.1.0 milestone Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant