Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plyranges: join_overlap but also include distance column #2

Open
mikelove opened this issue Aug 3, 2023 · 2 comments
Open

plyranges: join_overlap but also include distance column #2

mikelove opened this issue Aug 3, 2023 · 2 comments
Assignees
@mikelove
Labels
enhancement New feature or request

Comments

@mikelove
Copy link
Member

mikelove commented Aug 3, 2023 •
edited
Loading

As a crude example:

https://gist.github.com/mikelove/b855d493656438c0de64901d44b3eafc

Would be nice to allow this behavior within a function e.g. join_overlap_*_with_distance

Choices: 5', 3', center, classic distance?
@mikelove mikelove added the enhancement New feature or request label Aug 3, 2023
@mikelove mikelove transferred this issue from tidyomics/tidy-ranges-tutorial Aug 15, 2023
@jennprk jennprk self-assigned this Aug 15, 2023
@jennprk
Copy link

jennprk commented Aug 15, 2023

This is actually something I needed for my research. I'd love to make a function for this if it's still needed !

@mikelove mikelove changed the title Create a function that allows plyranges joins to also include distance column plyranges joins to also include distance column Sep 7, 2023
@mikelove mikelove changed the title plyranges joins to also include distance column plyranges: joins but also include distance column Sep 7, 2023
@mikelove mikelove changed the title plyranges: joins but also include distance column plyranges: join_overlap but also include distance column Sep 8, 2023
@mikelove mikelove self-assigned this Jan 26, 2024
@mikelove
Copy link
Member Author

Going to start working here
https://github.com/tidyomics/plyranges/tree/join_with_dist

Guiding ideas:

  • only for inner and left join, directed or not, but not for within
  • add a simple argument distance=FALSE so doesn't affect current pipelines
  • need to figure out logic behind distance... hopefully not implementing a lot of choices

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikelove mikelove

Labels
enhancement New feature or request
Projects
tidyomics open challenges
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikelove @jennprk