Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip snapshots with glue() error on R 4.3.3+ #210

Merged
merged 2 commits into from
Mar 4, 2024
Merged

skip snapshots with glue() error on R 4.3.3+ #210

merged 2 commits into from
Mar 4, 2024

Conversation

simonpcouch
Copy link
Contributor

Closes #209, related to tidymodels/parsnip#1078. :)

@simonpcouch
Copy link
Contributor Author

Looks like the couple additional skips affected RNG in survival/finetune snaps:

══ Failed ══════════════════════════════════════════════════════════════════════
── 1. Failure ('test-survival-tune_race_anova.R:1007:3'): race tuning (anova) su
Snapshot of code has changed:
old[5:12] vs new[5:12]
    # A tibble: 5 x 6
      cost_complexity .metric        .eval_time  mean     n std_err
                <dbl> <chr>               <dbl> <dbl> <int>   <dbl>
-   1    0.0000000001 brier_survival          1 0.177    30 0.00707
+   1          0.0841 brier_survival          1 0.201    30 0.00415
-   2    0.0841       brier_survival          1 0.201    30 0.00415
+   2          0.0891 brier_survival          1 0.201    30 0.00415

#194 made the opposite change, and sounds like we've seen this wonkiness when testing locally.

@simonpcouch
Copy link
Contributor Author

Bundled those snap changes into this PR so that we don't continue getting notifs after this is merged, though unrelated to these changes. Will go ahead and merge the accompanying parsnip PR and then this one.

@simonpcouch simonpcouch merged commit 0398048 into main Mar 4, 2024
5 checks passed
@simonpcouch simonpcouch deleted the fix-209 branch March 4, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new failures with glmnet penalty checks
1 participant