You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is nice in that we don't have to deal with known dependency resolution issues, but also means that installs can be overwritten by later ones, e.g. in #198, making it difficult to test against dev branches.
We could:
Try to install in an order that minimizes overwritten installs, and/or
Allow package dependency resolution for core packages by passing them as a vector to pak::pkg_install(), like:
This would mean that we're alerted when packages have circular dev dependencies, which is nice in the case where we did that accidentally but would require making temporary changes every time we do this knowingly.
The text was updated successfully, but these errors were encountered:
simonpcouch
changed the title
GH-R-CMD-CHECK workflow overwrites dev installsGH-R-CMD-CHECK workflow overwrites branch dev installs
Feb 27, 2024
GH-R-CMD-CHECK uses
try(pak::pkg_install())
for each dev package:extratests/.github/workflows/GH-R-CMD-check.yaml
Lines 61 to 83 in def7031
This is nice in that we don't have to deal with known dependency resolution issues, but also means that installs can be overwritten by later ones, e.g. in #198, making it difficult to test against dev branches.
We could:
pak::pkg_install()
, like:This would mean that we're alerted when packages have circular dev dependencies, which is nice in the case where we did that accidentally but would require making temporary changes every time we do this knowingly.
The text was updated successfully, but these errors were encountered: