Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-R-CMD-CHECK workflow overwrites branch dev installs #202

Closed
simonpcouch opened this issue Feb 27, 2024 · 0 comments · Fixed by #211
Closed

GH-R-CMD-CHECK workflow overwrites branch dev installs #202

simonpcouch opened this issue Feb 27, 2024 · 0 comments · Fixed by #211

Comments

@simonpcouch
Copy link
Contributor

GH-R-CMD-CHECK uses try(pak::pkg_install()) for each dev package:

try(pak::pkg_install("tidymodels/baguette"))
try(pak::pkg_install("tidymodels/bonsai"))
try(pak::pkg_install("tidymodels/censored"))
try(pak::pkg_install("tidymodels/dials"))
try(pak::pkg_install("tidymodels/discrim"))
try(pak::pkg_install("tidymodels/hardhat"))
try(pak::pkg_install("tidymodels/modeldata"))
try(pak::pkg_install("tidymodels/multilevelmod"))
try(pak::pkg_install("tidymodels/parsnip"))
try(pak::pkg_install("tidymodels/plsmod"))
try(pak::pkg_install("tidymodels/poissonreg"))
try(pak::pkg_install("tidymodels/recipes"))
try(pak::pkg_install("tidymodels/rsample"))
try(pak::pkg_install("tidymodels/rules"))
try(pak::pkg_install("tidymodels/spatialsample"))
try(pak::pkg_install("tidymodels/stacks"))
try(pak::pkg_install("tidymodels/themis"))
try(pak::pkg_install("tidymodels/tidymodels"))
try(pak::pkg_install("tidymodels/tune"))
try(pak::pkg_install("tidymodels/workflows"))
try(pak::pkg_install("tidymodels/yardstick"))
try(pak::pkg_install("tidymodels/finetune"))
try(pak::pkg_install("business-science/modeltime"))

This is nice in that we don't have to deal with known dependency resolution issues, but also means that installs can be overwritten by later ones, e.g. in #198, making it difficult to test against dev branches.

We could:

  1. Try to install in an order that minimizes overwritten installs, and/or
  2. Allow package dependency resolution for core packages by passing them as a vector to pak::pkg_install(), like:
try(pak::pkg_install(paste0("tidymodels/", c("rsample", "recipes", "parsnip", "dials", "workflows", "tune"))))

This would mean that we're alerted when packages have circular dev dependencies, which is nice in the case where we did that accidentally but would require making temporary changes every time we do this knowingly.

@simonpcouch simonpcouch changed the title GH-R-CMD-CHECK workflow overwrites dev installs GH-R-CMD-CHECK workflow overwrites branch dev installs Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant