Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test workflow_set() and workflow_map() for survival models #183

Merged
merged 1 commit into from
Jan 25, 2024
Merged

test workflow_set() and workflow_map() for survival models #183

merged 1 commit into from
Jan 25, 2024

Conversation

simonpcouch
Copy link
Contributor

Closes #119. :)

simonpcouch
simonpcouch commented Jan 23, 2024
View reviewed changes
tests/testthat/_snaps/survival-workflow-set.md
Warning in `tune::fit_resamples()`:
Evaluation times are only required when dynamic or integrated metrics are used (and will be ignored here).
Warning in `tune::fit_resamples()`:
Evaluation times are only required when dynamic or integrated metrics are used (and will be ignored here).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the duplicate warnings.👀

This is a little bit different than the similar output we saw for finetune, as users can vary options such that different workflows would experience different issues (so we can't just run the newly exported tune checking functions for one workflow and assume it's output applies elsewhere). Because of this, workflowsets doesn't deduplicate errors/warnings across tuning results.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the context here

@simonpcouch
Copy link
Contributor Author

These tests only run fit_resamples(). I'm on board if we want to put together another round of tests with tune_grid(), but there's very little conditional logic in finetune that differentiates between tune_grid() vs. fit_resamples() vs. others.

@simonpcouch simonpcouch requested a review from hfrick January 23, 2024 20:38
hfrick
hfrick approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 🌻

tests/testthat/_snaps/survival-workflow-set.md
Warning in `tune::fit_resamples()`:
Evaluation times are only required when dynamic or integrated metrics are used (and will be ignored here).
Warning in `tune::fit_resamples()`:
Evaluation times are only required when dynamic or integrated metrics are used (and will be ignored here).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the context here

@simonpcouch simonpcouch merged commit f26747a into main Jan 25, 2024
5 checks passed
@simonpcouch simonpcouch deleted the workflowsets-119 branch January 25, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfrick hfrick hfrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test workflow_set() and workflow_map() for survival models
2 participants
@simonpcouch @hfrick