Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uefi-sct/SctPkg: EFI_ADAPTER_INFORMATION_PROTOCOL Test #240

Open
Archi1986 opened this issue Jan 24, 2025 · 1 comment
Open

uefi-sct/SctPkg: EFI_ADAPTER_INFORMATION_PROTOCOL Test #240

Archi1986 opened this issue Jan 24, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@Archi1986
Copy link

The EFI_ADAPTER_INFORMATION_PROTOCOL Test 5.5.11.1.2 always FAILS with the AIP Support Type gEfiAdapterInfoNetworkBootGuid.

In the Guid C file, gEfiAdapterInfoUndiIPv6SupportGuid is assigned to an incorrect Guid.

Thanks.

uefi-sct\SctPkg\TestCase\UEFI\EFI\Protocol\AdapterInfo\BlackBoxTest\AdapterInfoBBTestMain.c

BOOLEAN
InfoTypeAndBlockSizeCmp( 
  EFI_GUID    InformationType,
  UINTN       InformationBlockSize
  )
{
   
  if ((!GuidCmp (InformationType,gEfiAdapterInfoMediaStateGuid) && InformationBlockSize != sizeof(EFI_ADAPTER_INFO_MEDIA_STATE)) || 
      (!GuidCmp (InformationType,gEfiAdapterInfoNetworkBootGuid) && InformationBlockSize != sizeof(EFI_ADAPTER_INFO_NETWORK_BOOT)) || 
      (!GuidCmp (InformationType,gEfiAdapterInfoSanMacAddressGuid) && InformationBlockSize != sizeof(EFI_ADAPTER_INFO_SAN_MAC_ADDRESS)) ||
      (!GuidCmp (InformationType,gEfiAdapterInfoUndiIPv6SupportGuid) && InformationBlockSize != sizeof(EFI_ADAPTER_INFO_UNDI_IPV6_SUPPORT)) ||
      (!GuidCmp (InformationType,gEfiAdapterInfoMediaTypeGuid) && InformationBlockSize != sizeof(EFI_ADAPTER_INFO_MEDIA_TYPE))) 
    return FALSE;
  else
    return TRUE;  
}

uefi-sct\SctPkg\TestCase\UEFI\EFI\Protocol\AdapterInfo\BlackBoxTest\Guid.c

EFI_GUID gEfiAdapterInfoMediaStateGuid              = EFI_ADAPTER_INFO_MEDIA_STATE_GUID;

EFI_GUID gEfiAdapterInfoSanMacAddressGuid           = EFI_ADAPTER_INFO_SAN_MAC_ADDRESS_GUID;

EFI_GUID gEfiAdapterInfoNetworkBootGuid             = EFI_ADAPTER_INFO_NETWORK_BOOT_GUID;

EFI_GUID gEfiAdapterInfoUndiIPv6SupportGuid         = EFI_ADAPTER_INFO_NETWORK_BOOT_GUID;
@edhay edhay added the bug Something isn't working label Feb 6, 2025
@edhay
Copy link
Contributor

edhay commented Feb 6, 2025

Hi @Archi1986 , Thank you for reporting this bug.
Could you please submit the solution patch for the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants