Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ Update test to add verification database records #1178

Merged
merged 2 commits into from
Apr 23, 2024
Merged

✅ Update test to add verification database records #1178

merged 2 commits into from
Apr 23, 2024

Conversation

estebanx64
Copy link
Contributor

No description provided.

tiangolo
tiangolo requested changes Apr 22, 2024
View reviewed changes
Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added a couple of comments, they also apply to a couple of extra places but it's the same idea. 🤓

backend/app/tests/api/routes/test_login.py Outdated Show resolved Hide resolved
backend/app/tests/api/routes/test_login.py Outdated Show resolved Hide resolved
backend/app/tests/api/routes/test_users.py Outdated Show resolved Hide resolved
@tiangolo tiangolo merged commit 933419e into master Apr 23, 2024
3 checks passed
@tiangolo tiangolo deleted the FL-353-asserts-db-test branch April 23, 2024 02:18
@tiangolo
Copy link
Member

Awesome, thanks! 🚀

@headingy headingy mentioned this pull request Jun 11, 2024
Merged
@gpspake gpspake mentioned this pull request Jul 26, 2024
Closed
gusevyaroslove pushed a commit to gusevyaroslove/fastapi-template that referenced this pull request Aug 4, 2024
@estebanx64
✅ Update test to add verification database records (fastapi#1178)
29764aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiangolo tiangolo tiangolo requested changes

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estebanx64 @tiangolo