Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Fix tests when first superuser password is changed in .env #1165

Merged
merged 2 commits into from
Apr 15, 2024
Merged

♻️ Fix tests when first superuser password is changed in .env #1165

merged 2 commits into from
Apr 15, 2024

Conversation

billzhong
Copy link
Contributor

The test_reset_password test changes user password. It will break other tests becuase get_superuser_token_headers function won't able to get access_token.

It relates to #217

@tiangolo tiangolo added the bug Something isn't working label Apr 15, 2024
@tiangolo
Copy link
Member

Makes sense, thank you @billzhong! 🚀

@tiangolo tiangolo enabled auto-merge (squash) April 15, 2024 21:26
@tiangolo tiangolo merged commit 3bd0d98 into fastapi:master Apr 15, 2024
3 checks passed
@billzhong billzhong deleted the patch-1 branch April 16, 2024 00:10
Pompeiro pushed a commit to Pompeiro/LTD2-DSS that referenced this pull request Apr 30, 2024
@headingy
Copy link

pity this got reverted by #1178

@gpspake
Copy link

gpspake commented Jul 26, 2024

pity this got reverted by #1178

@headingy There's a comment on #217 that this PR should have fixed the problem. It's still happening on current master, though, possibly because it got reverted as you mentioned. I left a comment to see if the issue could be reopened.

gusevyaroslove pushed a commit to gusevyaroslove/fastapi-template that referenced this pull request Aug 4, 2024
@pavgup
Copy link

pavgup commented Oct 13, 2024

Just confirming this patch looks like it was reverted. When it's applied, the backend tests will once again function!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants