Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactor rename ModelsOut to ModelsPublic #1154

Merged
merged 2 commits into from
Apr 6, 2024

Conversation

estebanx64
Copy link
Contributor

No description provided.

Copy link
Contributor

@patrick91 patrick91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a though, I've seen some codebase that uses ItemRead instead, but Public sounds good to me too 😊

@estebanx64
Copy link
Contributor Author

Just a though, I've seen some codebase that uses ItemRead instead, but Public sounds good to me too 😊

Sebastian just asked for it to be ModelsPublic for the output model which is exposing the response from services

@tiangolo tiangolo enabled auto-merge (squash) April 6, 2024 21:51
@tiangolo
Copy link
Member

tiangolo commented Apr 6, 2024

Great, thanks! 🚀

@tiangolo tiangolo merged commit ad72c4d into master Apr 6, 2024
3 checks passed
@tiangolo tiangolo deleted the FL-324-refactor-models-out-to-public branch April 6, 2024 21:53
gusevyaroslove pushed a commit to gusevyaroslove/fastapi-template that referenced this pull request Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants