🔥 Remove old/unused parameter sqlalchemy_safe from jsonable_encoder

[tiangolo]

🔥 Remove old/unused parameter sqlalchemy_safe from jsonable_encoder.

It was an early hack to allow returning SQLAlchemy models, but it was never documented, and the recommended way is using Pydantic's orm_mode as described in: https://fastapi.tiangolo.com/tutorial/sql-databases/

[codecov]

Codecov Report

Merging #1864 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1864   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          239       239           
  Lines         7079      7079           
=========================================
  Hits          7079      7079           

Impacted Files	Coverage Δ
fastapi/encoders.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64ca596...82e24ff. Read the comment docs.

[github-actions]

🚀 Deployed on https://5f305d2af5cc1faafbffdb8b--fastapi.netlify.app

[shawnwall]

I can't quite figure out if this was the commit that did it, but if you try to do the following now you get a stack overflow:

obj_data = jsonable_encoder(some_sqla_model_instance)

This breaks the update pattern found in https://github.com/tiangolo/full-stack-fastapi-postgresql/blob/master/%7B%7Bcookiecutter.project_slug%7D%7D/backend/app/app/crud/base.py

[mvilanova]

All our Pydantic models inherit from the same base model which has orm_mode = True and we're also getting a stack overflow.

[tiangolo]

Thanks for pointing this out @shawnwall and @mvilanova ! 🔍 🐛

I reverted it in #1987 , available in FastAPI version 0.61.1 (released today in a couple of hours).