Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export WebSocketDisconnect and add example handling disconnections to docs #1822

Merged
merged 5 commits into from
Aug 9, 2020

Conversation

rkbeatss
Copy link
Contributor

@rkbeatss rkbeatss commented Jul 31, 2020

PR for #1799 : Adding documentation for multiple clients and what happens when a client closes WebSocket

@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #1822 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master     #1822    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          235       238     +3     
  Lines         6989      7094   +105     
==========================================
+ Hits          6989      7094   +105     
Impacted Files Coverage Δ
.../test_tutorial/test_websockets/test_tutorial003.py 100.00% <100.00%> (ø)
fastapi/params.py 100.00% <0.00%> (ø)
fastapi/routing.py 100.00% <0.00%> (ø)
fastapi/encoders.py 100.00% <0.00%> (ø)
fastapi/exceptions.py 100.00% <0.00%> (ø)
fastapi/applications.py 100.00% <0.00%> (ø)
fastapi/security/http.py 100.00% <0.00%> (ø)
fastapi/param_functions.py 100.00% <0.00%> (ø)
fastapi/security/api_key.py 100.00% <0.00%> (ø)
fastapi/dependencies/utils.py 100.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a63b1ef...eaadfde. Read the comment docs.

@rkbeatss rkbeatss marked this pull request as draft July 31, 2020 19:50
@rkbeatss rkbeatss marked this pull request as ready for review July 31, 2020 19:55
@github-actions
Copy link
Contributor

📝 Docs preview for commit 0f390ed at: https://5f247b1250231f85bbed1881--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit e5d7d78 at: https://5f2488b350231f2ad0ed1fcf--fastapi.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2020

📝 Docs preview for commit fa43455 at: https://5f2c3991865d01cf3361311f--fastapi.netlify.app

@tiangolo tiangolo changed the title Added web sockets exception Export WebSocketDisconnect and add example handling disconnections to docs Aug 9, 2020
@tiangolo tiangolo merged commit 5ed48cc into fastapi:master Aug 9, 2020
@tiangolo
Copy link
Member

tiangolo commented Aug 9, 2020

Excellent job @rkbeatss ! Thanks! 🚀 🎉 🤓 🍰

Thanks for the help @Kludex and @teymour-aldridge ! ☕ 🍫

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants