Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added flake8 #1774

Merged
merged 8 commits into from
Aug 9, 2020
Merged

Added flake8 #1774

merged 8 commits into from
Aug 9, 2020

Conversation

n25a
Copy link
Contributor

@n25a n25a commented Jul 22, 2020

I added flake8 plugin for validating Python code style.
flake8 added to dependencies list, format script to format and clean all your code, and test script.
I ran flake8 on all files in fastapi and tests and changed them as well.

@n25a n25a changed the title Add flake8 Added flake8 Jul 22, 2020
@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #1774 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1774   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          235       237    +2     
  Lines         6989      7078   +89     
=========================================
+ Hits          6989      7078   +89     
Impacted Files Coverage Δ
fastapi/security/oauth2.py 100.00% <ø> (ø)
tests/test_application.py 100.00% <ø> (ø)
tests/test_request_body_parameters_media_type.py 100.00% <ø> (ø)
tests/test_tutorial/test_body/test_tutorial001.py 100.00% <ø> (ø)
fastapi/routing.py 100.00% <100.00%> (ø)
tests/test_dependency_class.py 100.00% <100.00%> (ø)
tests/test_dependency_contextmanager.py 100.00% <100.00%> (ø)
tests/test_jsonable_encoder.py 100.00% <100.00%> (ø)
tests/test_response_by_alias.py 100.00% <100.00%> (ø)
tests/test_security_oauth2.py 100.00% <100.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42f1716...1001055. Read the comment docs.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 0061e18 at: https://5f18c7250bdaa8d009104c2a--fastapi.netlify.app

@tiangolo tiangolo merged commit da9b520 into fastapi:master Aug 9, 2020
@tiangolo
Copy link
Member

tiangolo commented Aug 9, 2020

Great, thanks! 🚀 🎨

I updated the configs (based on Black) and a couple of sections in the tests to conform to the new rules. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants