You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I recently started using this gem and have found it quite useful. Thanks. However I tried to use jsonapi_render_bad_request and I got the following error:
It looks like the original refactoring to split up the exceptions into separate files resulted in BadRequest getting skipped/forgotten.
It seems, and this is without knowing the current design philosophy, updating jsonapi_render_bad_request to use JSONAPI::Exceptions::BadRequest directly, overriding detail: to match the original Utils BadRequest implementation could be one solution.
Another would be to implement JSONAPI::Utils::Exceptions::BadRequest.
Another would be to remove jsonapi_render_bad_request.
I'm happy to submit a pull request for any of those proposed solutions.
The text was updated successfully, but these errors were encountered:
Howdy!
I'm using the following gems:
I recently started using this gem and have found it quite useful. Thanks. However I tried to use
jsonapi_render_bad_request
and I got the following error:It looks like the original refactoring to split up the exceptions into separate files resulted in BadRequest getting skipped/forgotten.
It seems, and this is without knowing the current design philosophy, updating
jsonapi_render_bad_request
to useJSONAPI::Exceptions::BadRequest
directly, overridingdetail:
to match the originalUtils BadRequest
implementation could be one solution.Another would be to implement
JSONAPI::Utils::Exceptions::BadRequest
.Another would be to remove
jsonapi_render_bad_request
.I'm happy to submit a pull request for any of those proposed solutions.
The text was updated successfully, but these errors were encountered: