-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove outdated prefixes #334
Comments
yeah, prefixes are dead, let's have them optional pls |
cc @brijeshb42 adding this in your radar. It fits well under the "improving the style engine of MUI" north start objective of your team (so far 1 person but hopefully we can grow this). |
I think the loose goal of the prefixer here is to prefix as much as possible. Different people might have different needs and all. This prefixed can be manually trimmed down by people - this is what we were already doing in Emotion to avoid prefixing grid. We are also further trimming it down for the upcoming major version of Emotion, see: emotion-js/emotion#3296 |
Stylis includes a prefixer module:
This is very helpful as there are CSS properties that need vendor prefixes. For example,
user-select: none;
still requires it in browsers that have an important global usage rate.However, I have noticed a couple of prefixes that I would argue are more harmful than beneficial. Mainly, the flexbox properties. The global need for the prefix seems to be 0.48% (0.01 + 0.14 + 0.05 + 0.01 + 0.02 + 0.03 + 0.01 + 0.1 + 0.11). Do we need to keep it, at this point?
By removing it, we would gain:
Before
After is so much better:
Actually, this might simply be the root cause of a different problem: What's the browser support target? Do we have something like this https://github.com/kripod/style-vendorizer#browser-support?
The text was updated successfully, but these errors were encountered: