fix(presets): remove moduleNameMapper config
#910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahnpnl
added
the
💣 Breaking Changes
BREAKING CHANGE When generating a new project from Angular CLI, by default the `tsconfig.json` doesn't contain any path mappings hence removing `moduleNameMapper` from preset will make sure that the preset works in pair with `tsconfig.json`. Ones who are relying on the value of `moduleNameMapper` from the preset should create their own `moduleNameMapper` config manually or via `ts-jest` util https://kulshekhar.github.io/ts-jest/docs/getting-started/paths-mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove
moduleNameMapperconfig from both presets, CJS and ESMCloses #908
Test plan
Green CI
Does this PR introduce a breaking change?
When generating a new project from Angular CLI, by default the
tsconfig.jsondoesn't contain any path mappings hence removingmoduleNameMapperfrom preset will make sure that the preset works in pair withtsconfig.json.Ones who are relying on the value of
moduleNameMapperfrom the preset should create their ownmoduleNameMapperconfig manually or viats-jestutil https://kulshekhar.github.io/ts-jest/docs/getting-started/paths-mappingOther information
N.A.