Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong generation into PNG(need support mask-type) #205

Closed
tarasom opened this issue Feb 8, 2023 · 2 comments · Fixed by #268
Closed

Wrong generation into PNG(need support mask-type) #205

tarasom opened this issue Feb 8, 2023 · 2 comments · Fixed by #268
Labels
dependencies Pull requests that update a dependency file

Comments

@tarasom
Copy link

tarasom commented Feb 8, 2023

During convertation from SVG to PNG I lost some context of my image (red and grey colors):
Source:
text

Target:
text-out

On the other hand everything is ok if I generate similar image
Source:
text

Target:
text-out

Could you help me to identify what is a root cause of that. Is this really an issue with library or there some limitations. Thanks!
@yisibl
Copy link
Member

yisibl commented Feb 8, 2023 •
edited
Loading

I also lost the color when I opened it directly in the browser.

I see, resvg does not yet support the mask-type attribute. Please go upstream and submit a feature request, thanks.
https://github.com/RazrFalcon/resvg/issues

https://github.com/RazrFalcon/resvg/blob/master/docs/svg2-changelog.md#clipping-masking-and-compositing

@yisibl yisibl added the dependencies Pull requests that update a dependency file label Aug 7, 2023
@yisibl yisibl changed the title Wrong generation into PNG Wrong generation into PNG(need support mask-type) Aug 7, 2023
@yisibl
Copy link
Member

yisibl commented Aug 7, 2023 •
edited
Loading

The mask-type is already supported in upstream resvg v0.32, some work is needed in resvg-js to upgrade to the latest version.

@zimond zimond mentioned this issue Sep 23, 2023
Closed
@zimond zimond mentioned this issue Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: upgrade to usvg/resvg 0.34.0 thx/resvg-js
feat: upgrade to usvg/resvg 0.34 thx/resvg-js
2 participants
@tarasom @yisibl