Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response tab colors #243

Closed
davioliveira-dev opened this issue Jun 29, 2021 · 8 comments
Closed

Response tab colors #243

davioliveira-dev opened this issue Jun 29, 2021 · 8 comments
Labels
feature request New feature or request

Comments

@davioliveira-dev
Copy link

Is your feature request related to a problem? Please describe.
The response tab does not have the colors of the current vscode theme, the json response always comes in the default theme (Dark+)

image

I switched themes and this issue continues.

Describe the solution you'd like
Just get the current color scheme from vscode and apply to Response tab (on json response)

Describe alternatives you've considered
None

Implementation:

@rangav
Copy link
Collaborator

rangav commented Jun 29, 2021

Hi @davioliveira-dev Will add this to roadmap.

@rangav rangav added the feature request New feature or request label Jun 29, 2021
@rangav
Copy link
Collaborator

rangav commented Jan 19, 2022

Hi @davioliveira-dev, Looks like vscode did not expose the editor themes to extensions yet

please see this issue in vscode repo microsoft/vscode#56356

@APerricone
Copy link

for this kind of thing are not sufficient the css variables? in my extension I obtains good result... for example https://github.com/APerricone/vscode-dbf/blob/master/media/style.css

@rangav
Copy link
Collaborator

rangav commented Jan 19, 2022

@APerricone they are not sufficient, I am also using those css variables for extension theme, but for code editor part is not sufficient

If you know how to use them in vscode webviews for code syntax highlighting let me know

@APerricone
Copy link

APerricone commented Jan 20, 2022

as we see on microsoft/vscode#56356 they use shiva , I can see on the page it says "But really, any VS Code theme will do" I think you can use window.activeColorTheme. I have not tried

@rangav
Copy link
Collaborator

rangav commented Jan 20, 2022

@APerricone Thanks - Will give it a try and see if it works.

@rangav rangav changed the title 💄 Response tab colors Response tab colors Sep 13, 2022
@rangav
Copy link
Collaborator

rangav commented Sep 15, 2022

This feature is now implemented and published to marketplace, please update to v1.19.0

See all features released
https://github.com/rangav/thunder-client-support/releases/tag/v1.19.0

Please let me know your feedback.

@rangav rangav closed this as completed Sep 15, 2022
@ejabu
Copy link

ejabu commented Sep 11, 2023

@rangav how can you do it ? did vscode provide you new API to interact with ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants