Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Down arrowhead icons on compose page have no accessible name #8232

Closed
2 tasks done
dankeck opened this issue Oct 3, 2024 · 5 comments · Fixed by #8692
Closed
2 tasks done

Down arrowhead icons on compose page have no accessible name #8232

dankeck opened this issue Oct 3, 2024 · 5 comments · Fixed by #8692
Labels
good first issue Ideal for newcomers to start contributing type: accessibility Issues related to improving accessibility for all users type: bug Something is causing incorrect behavior or errors

Comments

@dankeck
Copy link

dankeck commented Oct 3, 2024

Checklist

  • I have used the search function to see if someone else has already submitted the same bug report.
  • I will describe the problem with as much detail as possible.

App version

8.0b1

Where did you get the app from?

Google Play

Android version

14

Device model

Pixel 5

Steps to reproduce

  1. Start the Android TalkBack screen reader.
  2. Open Thunderbird Beta.
  3. Compose a new email message.
  4. Use TalkBack to navigate to the down arrowhead icon next to the From field, or the icon next to the To field.
    Compose screen highlighting a down arrowhead icon next to the From field. The same icon also appears next to the To field.

Expected behavior

TalkBack says the purpose of the button, such as "more" or "expand" or "additional fields".

Actual behavior

TalkBack says "unlabeled button" and does not convey the purpose of the button.

Logs

No response
@dankeck dankeck added type: bug Something is causing incorrect behavior or errors unconfirmed Newly reported issues awaiting triage or confirmation labels Oct 3, 2024
@kewisch kewisch added good first issue Ideal for newcomers to start contributing type: accessibility Issues related to improving accessibility for all users and removed unconfirmed Newly reported issues awaiting triage or confirmation labels Oct 18, 2024
@mececeli
Copy link

mececeli commented Dec 8, 2024 •
edited
Loading

I would like to work on this issue. @kewisch @dankeck

@williamspiegel williamspiegel mentioned this issue Dec 19, 2024
Merged
@Akshaykomar890
Copy link

Hi @kewisch I'd like to work on this issue. Could you please assign it to me?

@kewisch
Copy link
Member

kewisch commented Jan 2, 2025

Hey folks, we were off towards the end of the year so I couldn't respond earlier. @mececeli have you had success with a PR on this issue? This generally seems simple enough that someone could just go ahead and send a pull request, but of course I don't want to duplicate the work if someone has already started.

@mececeli
Copy link

mececeli commented Jan 2, 2025

Hey folks, we were off towards the end of the year so I couldn't respond earlier. @mececeli have you had success with a PR on this issue? This generally seems simple enough that someone could just go ahead and send a pull request, but of course I don't want to duplicate the work if someone has already started.

Hey there! I made a fix on my local, but looks like somebody already raised a PR above, which looks like similar to my fix. Next time I can raise PR for these kind of bugs. See you on the next bugs, happy to contribute!

@kewisch
Copy link
Member

kewisch commented Jan 2, 2025

Thanks for sticking with us, I'm looking forward to see what is next for you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Ideal for newcomers to start contributing type: accessibility Issues related to improving accessibility for all users type: bug Something is causing incorrect behavior or errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add accessible name for expand icon in compose screen williamspiegel/thunderbird-android
4 participants
@kewisch @mececeli @dankeck @Akshaykomar890