From 264c648f49de075075e3c22dc0df412e4d6c2715 Mon Sep 17 00:00:00 2001 From: Killesreiter Volker Date: Wed, 14 Aug 2024 10:35:54 +0200 Subject: [PATCH 1/3] Add focal_point patch --- composer.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/composer.json b/composer.json index a5d402f6a..493202f1f 100644 --- a/composer.json +++ b/composer.json @@ -41,6 +41,9 @@ "drupal/diff": { "Back button for comparison page": "https://www.drupal.org/files/issues/back_button_for-2853193-4.patch" }, + "drupal/focal_point": { + "Issue #3462165: Preview results in Error: Call to a member function getDefinitions() on null": "https://www.drupal.org/files/issues/2024-07-18/Preview-results-in-Error-3462165.patch" + }, "drupal/gin": { "Issue #3455558: There is no visible change to a toggle when pressed (but it does trigger conditional fields, value is saved, etc)": "https://www.drupal.org/files/issues/2024-08-06/3455558-Refactor-toggle-styles-mr438.patch" }, From 3637278788332a7015face8b06d669a2dcbbda90 Mon Sep 17 00:00:00 2001 From: Killesreiter Volker Date: Wed, 14 Aug 2024 14:59:43 +0200 Subject: [PATCH 2/3] Failing test --- composer.json | 3 --- .../Integration/FocalPointTest.php | 25 +++++++++++++++++++ 2 files changed, 25 insertions(+), 3 deletions(-) create mode 100644 tests/src/FunctionalJavascript/Integration/FocalPointTest.php diff --git a/composer.json b/composer.json index 851b37795..cff7bf130 100644 --- a/composer.json +++ b/composer.json @@ -41,9 +41,6 @@ "drupal/diff": { "Back button for comparison page": "https://www.drupal.org/files/issues/back_button_for-2853193-4.patch" }, - "drupal/focal_point": { - "Issue #3462165: Preview results in Error: Call to a member function getDefinitions() on null": "https://www.drupal.org/files/issues/2024-07-18/Preview-results-in-Error-3462165.patch" - }, "drupal/gin": { "Issue #3455558: There is no visible change to a toggle when pressed (but it does trigger conditional fields, value is saved, etc)": "https://www.drupal.org/files/issues/2024-08-06/3455558-Refactor-toggle-styles-mr438.patch" }, diff --git a/tests/src/FunctionalJavascript/Integration/FocalPointTest.php b/tests/src/FunctionalJavascript/Integration/FocalPointTest.php new file mode 100644 index 000000000..cfa49561d --- /dev/null +++ b/tests/src/FunctionalJavascript/Integration/FocalPointTest.php @@ -0,0 +1,25 @@ +loadNodeByUuid('0bd5c257-2231-450f-b4c2-ab156af7b78d'); + $this->drupalGet($node->toUrl('edit-form')); + $this->clickDrupalSelector('edit-field-teaser-media-selection-0-edit'); + $this->clickDrupalSelector('edit-field-image-0-preview-preview-link'); + + $this->assertSession()->elementExists('css', '#focal-point-derivatives .focal-point-derivative-preview-image'); + $this->assertSession()->elementExists('css', '.focal-point-original-image > #focal-point-preview-image'); + } + +} From 867540c024f118b6c659f1cf64e9c4d911185b8b Mon Sep 17 00:00:00 2001 From: Killesreiter Volker Date: Wed, 14 Aug 2024 15:22:20 +0200 Subject: [PATCH 3/3] add patch --- composer.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/composer.json b/composer.json index cff7bf130..b14b9f3c9 100644 --- a/composer.json +++ b/composer.json @@ -41,6 +41,9 @@ "drupal/diff": { "Back button for comparison page": "https://www.drupal.org/files/issues/back_button_for-2853193-4.patch" }, + "drupal/focal_point": { + "Issue #3462165: Preview results in Error: Call to a member function getDefinitions() on null": "https://www.drupal.org/files/issues/2024-07-18/Preview-results-in-Error-3462165.patch" + }, "drupal/gin": { "Issue #3455558: There is no visible change to a toggle when pressed (but it does trigger conditional fields, value is saved, etc)": "https://www.drupal.org/files/issues/2024-08-06/3455558-Refactor-toggle-styles-mr438.patch" },