Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would support other headdim #17

Closed
v4if opened this issue Oct 22, 2024 · 2 comments
Closed

Would support other headdim #17

v4if opened this issue Oct 22, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@v4if
Copy link

v4if commented Oct 22, 2024

Would support other headdim? Like 512.

@v4if v4if changed the title would support other headdim Would support other headdim Oct 22, 2024
@jason-huang03
Copy link
Member

In the upcoming release, we will include kernels for head dimension of 256. However, models with a head dimension of 256 are already quite rare (only gemma-2 2b/9b as far as I know), and those with 512 are even more uncommon. Could you provide examples of models that use a head dimension of 512? This would give us a stronger incentive to optimize this type of kernel.

@jason-huang03 jason-huang03 added the enhancement New feature or request label Oct 28, 2024
@v4if
Copy link
Author

v4if commented Oct 28, 2024

In the upcoming release, we will include kernels for head dimension of 256. However, models with a head dimension of 256 are already quite rare (only gemma-2 2b/9b as far as I know), and those with 512 are even more uncommon. Could you provide examples of models that use a head dimension of 512? This would give us a stronger incentive to optimize this type of kernel.

tks. internal model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants