Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time zone of timestamps #184

Closed
ByteHamster opened this issue Oct 20, 2024 · 2 comments · Fixed by #187
Closed

Time zone of timestamps #184

ByteHamster opened this issue Oct 20, 2024 · 2 comments · Fixed by #187

Comments

@ByteHamster
Copy link

Hi,

when looking into AntennaPod/AntennaPod#7453, I noticed that this nextcloud plugin does not seem to support specifying a time zone for the timestamps:

private const DATETIME_FORMAT = 'Y-m-d\TH:i:s';

To work around issues with server time zones, I am considering to explicitly send the time zone in AntennaPod's requests. The gpodder documentation just states that the time zone should be ISO 8601. While their examples do not specify the time zone, the ISO 8601 does cover time zones as well.

I unfortunately don't have a nextcloud server to test currently, so I am asking here. Would sending time zones break parsing in this nextcloud plugin?

@JonOfUs
Copy link
Collaborator

JonOfUs commented Nov 27, 2024

Hi,

sorry for the late reply.

It seems like this app currently does not support timezones and we expect all timestamps to be in UTC.
I think this should be changed on our side, the app currently crashes if e.g. 2024-11-27T00:00:00+01:00 comes in. However, since we cannot make sure that all Nextcloud servers would receive such an update in the near future, would it be problematic if AntennaPod just continues to send timestamps in UTC?

@ByteHamster
Copy link
Author

The problem is that people blame AntennaPod for any problems caused by the web server using different time zones. There are currently implementations of podcast servers, so there is no way we can make sure that they all use UTC. So we should really send the time zone to make sure that the time stamps are correct.

For Nextcloud, I suggest to implement the feature on the server. Then we wait a few months until everyone had the chance to upgrade. Then we release the time zones in AntennaPod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants