Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting a large profile picture will not allow a connection to Threema Web #768

Closed
joelfischerr opened this issue Mar 4, 2019 · 2 comments
Labels
bug It's a bug! os-ios Concerns the iOS app

Comments

@joelfischerr
Copy link
Contributor

Expected Behavior

Setting a new profile picture in Threema Web should have no side effects except that the profile picture is updated.

Current Behavior

When setting a new profile picture from a large jpeg the iOS app will not be able to reconnect on the next session. It will get stuck on 99%.

Possible Solution

Check the size of the profile picture.

Steps to Reproduce (for bugs)

  1. Set a new profile picture that is quite large such as this one in Threema Web: https://unsplash.com/photos/loGTCYD03n0
  2. Refresh the page
  3. Try to connect to Threema Web again
  4. It will get stuck on 99% (at least on my connection, maybe it has something to do with connection speed)

Your Environment

  • Threema Web version: 2.1.7
  • Threema App version: 4.1.2, 4.1.1
  • Browser name and version: Firefox 65.0.1 and any other browser
  • Computer operating system and version: macOS
  • Smartphone operating system and version: iOS 12.1.4
@lgrahl lgrahl added bug It's a bug! app-update Requires an app update os-ios Concerns the iOS app and removed app-update Requires an app update labels Mar 7, 2019
@lgrahl
Copy link
Contributor

lgrahl commented Mar 7, 2019

Investigated and found a race condition between response/receivers and response/profile where the former depends on the latter being processed. Due to the size of the profile picture, the response/receivers has been received before response/profile. Will be fixed in the next release.

However, there are two more issues:

  1. The picture should have been resized to 512x512 by the web client, filed Avatars should be resized to 512x512 #770.
  2. The app should resize the image regardless of whether the web client already did. This obviously requires an app update.

@joelfischerr
Copy link
Contributor Author

I have not looked into it very thoroughly but the large profile picture seemed to have also caused the iOS app to become slow and reload many profile/group pictures each time the chat list is loaded. Setting a new picture to all groups I have created through Threema Web has increased responsiveness of the iOS app.
It might be worth it to resize all existing profile/group pictures or at least to keep it in mind for the support team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug! os-ios Concerns the iOS app
Development

No branches or pull requests

2 participants