Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple issues with compose area and drafts #376

Merged
merged 1 commit into from
Nov 23, 2017
Merged

Conversation

dbrgn
Copy link
Contributor

@dbrgn dbrgn commented Nov 15, 2017

  • Sometimes the compose area would think it's non empty even when it is (e.g. when inserting a newline and deleting it again)
  • Drafts did not store emoji
  • Sometimes it was possible to submit text only consisting of whitespace characters, resulting in an error message

The empty checking is now unified and always uses the getText() function.

- Sometimes the compose area would think it's non empty even when it
  just contains a single <br>
- Drafts did not store emoji
- Sometimes it was possible to submit text only consisting of
  whitespace characters, resulting in an error message

The empty checking is now unified and always uses the `getText()`
function.
@dbrgn dbrgn added the bug It's a bug! label Nov 15, 2017
@dbrgn dbrgn requested a review from sillych November 15, 2017 14:30
Copy link
Contributor

@sillych sillych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good....

@sillych sillych merged commit 1d2e33b into master Nov 23, 2017
@dbrgn dbrgn deleted the compose-area-fixes branch November 23, 2017 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug!
Development

Successfully merging this pull request may close these issues.

3 participants